Add method fn Generator::drop #35
Merged
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I do not wish to add a An alternative is the unconstrained-buffer approach formerly used in #24, though we moved away from that approach for a good reason. |
baloo
approved these changes
Dec 9, 2025
Member
Author
|
Good, we have a solution. |
Member
|
As I wrote here, I really don't like this solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Add
fn dropto traitGeneratorMotivation
See this comment.
This allows the generator to add a destruction hook such as a call to zeroize the output buffer.
@baloo I think this suffices for the needs of
chacha20?